-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add opentelemetry tracer and metrics #679
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hf
force-pushed
the
hf/opentelemetry
branch
2 times, most recently
from
September 15, 2022 11:42
132e348
to
4cbbc31
Compare
This was referenced Sep 15, 2022
hf
force-pushed
the
hf/opentelemetry
branch
from
September 15, 2022 13:43
4cbbc31
to
2ee7597
Compare
hf
force-pushed
the
hf/opentelemetry
branch
5 times, most recently
from
September 16, 2022 08:06
7e996b6
to
abdf10e
Compare
hf
force-pushed
the
hf/opentelemetry
branch
2 times, most recently
from
September 16, 2022 12:12
d738273
to
dcf59b5
Compare
hf
force-pushed
the
hf/opentelemetry
branch
2 times, most recently
from
September 16, 2022 13:29
90ea76b
to
b770f70
Compare
hf
force-pushed
the
hf/opentelemetry
branch
from
September 16, 2022 14:10
b770f70
to
d75e194
Compare
hf
force-pushed
the
hf/opentelemetry
branch
2 times, most recently
from
September 22, 2022 12:25
e35f79c
to
8d0c3a4
Compare
hf
commented
Sep 22, 2022
Hey @kangmingtay, @J0, @HarryET this is now small enough to be reviewed. I suggest creating a free account on honeycomb.io and following the instructions in the PR to see the traces. Metrics can be seen by using the Prometheus exporter and visiting localhost:9100. |
kangmingtay
approved these changes
Sep 26, 2022
hf
force-pushed
the
hf/opentelemetry
branch
from
September 26, 2022 08:38
cbde419
to
9363d02
Compare
hf
force-pushed
the
hf/opentelemetry
branch
from
September 26, 2022 08:43
9363d02
to
f82303b
Compare
🎉 This PR is included in version 2.17.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
J0
added a commit
that referenced
this pull request
Nov 12, 2023
## What kind of change does this PR introduce? As per [this PR](#679) and the we have deprecated opentracing and are removing it in favour of opentelemetry. This will make the update of the opentelemetry dependcies easier as we no longer have to consider opentracing specific dependencies. Relevant internal context: https://supabase.slack.com/archives/C022071RB2L/p1699451083111579 --------- Co-authored-by: joel@joellee.org <joel@joellee.org>
uxodb
pushed a commit
to uxodb/auth
that referenced
this pull request
Nov 13, 2024
* feat: add opentelemetry tracing and metrics * docs: update README * refactor: use OTEL standard vars for prometheus Co-authored-by: HarryET <29015545+HarryET@users.noreply.github.com>
uxodb
pushed a commit
to uxodb/auth
that referenced
this pull request
Nov 13, 2024
## What kind of change does this PR introduce? As per [this PR](supabase#679) and the we have deprecated opentracing and are removing it in favour of opentelemetry. This will make the update of the opentelemetry dependcies easier as we no longer have to consider opentracing specific dependencies. Relevant internal context: https://supabase.slack.com/archives/C022071RB2L/p1699451083111579 --------- Co-authored-by: joel@joellee.org <joel@joellee.org>
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 13, 2024
* feat: add opentelemetry tracing and metrics * docs: update README * refactor: use OTEL standard vars for prometheus Co-authored-by: HarryET <29015545+HarryET@users.noreply.github.com>
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 13, 2024
## What kind of change does this PR introduce? As per [this PR](supabase#679) and the we have deprecated opentracing and are removing it in favour of opentelemetry. This will make the update of the opentelemetry dependcies easier as we no longer have to consider opentracing specific dependencies. Relevant internal context: https://supabase.slack.com/archives/C022071RB2L/p1699451083111579 --------- Co-authored-by: joel@joellee.org <joel@joellee.org>
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 15, 2024
* feat: add opentelemetry tracing and metrics * docs: update README * refactor: use OTEL standard vars for prometheus Co-authored-by: HarryET <29015545+HarryET@users.noreply.github.com>
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 15, 2024
## What kind of change does this PR introduce? As per [this PR](supabase#679) and the we have deprecated opentracing and are removing it in favour of opentelemetry. This will make the update of the opentelemetry dependcies easier as we no longer have to consider opentracing specific dependencies. Relevant internal context: https://supabase.slack.com/archives/C022071RB2L/p1699451083111579 --------- Co-authored-by: joel@joellee.org <joel@joellee.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for OpenTelemetry tracing and metrics, in addition to the existing support for OpenTracing via DataDog.
Please consult the README on how to configure it. Here are some excerpts:
Tracing
Metrics
(OpenTracing is being deprecated as of this PR, will be removed in the next few releases.)
Builds upon the excellent work by @HarryET in #524.